[Xastir-Dev] Xastir Opentrac bug
Henk de Groot
henk.de.groot at hetnet.nl
Sat Oct 25 16:51:07 EDT 2003
Hello,
Am I the first one to report a bug on the Opentrac support in Xastir? Just
a minor thing, but it is always nice to be first :-).
I created some Opentrac packets to test on DIGI_NED and decided to throw
them also at Xastir to see what happens.
It showed up as an "Ent 1" object with (almost) the correct information...
Nice! I say almost correct since the "network" value was not correct, it
has a bug which I also found in the "opentrac" modified "listen" command
(not reported however, I'm not on the Opentrac mailing list). A classic
off-by-one error, you need the 9th byte so you need to fetch
*(element+8)... I tripple (or quardrupple) checked the (current)
specification, its realy 1 byte directly following the sequence number...
Patch:
--- xastir/src/interface.c.orig Sat Oct 25 22:22:22 2003
+++ xastir/src/interface.c Sat Oct 25 22:24:10 2003
@@ -1260,7 +1260,7 @@
*sequence = fetch16bits(element+6);
if (element_len == 9) {
- *network = *(element+9);
+ *network = *(element+8);
fprintf(stderr, "Origin: %s-%d seq %d net %d\n",
callsign,
I guess this gets mangled again by Eudora but its simple to apply by hand
also. (I still need to install an older Eudora version to get rid of the
stupid "rich" formatting).
Kind regards,
Henk.
More information about the Xastir-dev
mailing list